Fix jpegOrientation for camera sensors not at 90 degrees

infinum / Android-GoldenEye

A wrapper for Camera1 and Camera2 API which exposes simple to use interface.

Apache License 2.0

376 stars 53 forks source link

Fix jpegOrientation for camera sensors not at 90 degrees #5

Closed reisub closed 8 years ago

reisub commented 8 years ago

Verified with turning my phone in all directions and taking pictures! Also works correctly for the front camera on my Nexus 5X.

Please test on your Nexus 6, it has a 90 degree mounted camera in the back and a 270 degree camera mounted in the front (for the 5X it's the other way around).

reisub commented 8 years ago

Fixes #3. :)

jmarkovic commented 8 years ago

Code looks good, I'm glad it fixes your problem. I will have to test on usual suspects just to avoid any regressions. Turning your phone does not break the layout and camera preview?

Also, I'll probably add Exif information in save process to this PR, I believe Nexus 5X did not write anything when we tested.

reisub commented 8 years ago

Turning works great for me. Check the exif info first, this might even add it - I'm not sure.