infinum / Android-GoldenEye

A wrapper for Camera1 and Camera2 API which exposes simple to use interface.
Apache License 2.0
375 stars 53 forks source link

Handle exceptions in a sane manner rather than swallowing them #9

Closed jmarkovic closed 5 years ago

jmarkovic commented 7 years ago

More often than not, exceptions are just swallowed by a try / catch block. For example:

Camera2Api Camera2Api Camera1Api

These are just 3 examples out of many.

Consider creating specific exceptions for this library, but don't overdo it. If the app has to crash, so be it. Consider creating an option that will swallow exceptions (maybe settable in the Config class).