search

infinum / Android-Goldfinger

Android library to simplify Biometric authentication implementation.
Apache License 2.0
653 stars 73 forks source link

RxGoldfinger - Critical errors to onError() #35

Closed domagojkorman closed 5 years ago

domagojkorman commented 6 years ago

@antunflas suggested to wrap Critical errors into GoldfingerException and throw them to Observable's onError method. I agree that it makes more sense semantically as we do not send any more events after critical error happens.

I am just not sure would it make sense to have recoverable errors in onNext and unrecoverable in onError as we created Error API with isCritical() method. In that case, for Rx module, that method would not even be necessary.

What is your opinion?

@mariciv @dmarusic35 @ikocijan @zplesac

domagojkorman commented 5 years ago

I think we did this even better in the end in the new v1.2.0 version. Closing issue