search

infinum / Android-Goldfinger

Android library to simplify Biometric authentication implementation.
Apache License 2.0
653 stars 73 forks source link

`Error.isCritical` semantics #38

Closed domagojkorman closed 5 years ago

domagojkorman commented 6 years ago

Might think a bit more about semantics in Error enum. isCritical can be misleading because LOCKOUT is not critical, it just means that user has to wait for retry.

I personally think we should introduce something like Severity so that we can have better granulation over enums.

domagojkorman commented 5 years ago

Result is completely refactored. This is not an issue anymore.