search

infinum / android_dbinspector

Android library for viewing, editing and sharing in app databases.
Apache License 2.0
952 stars 92 forks source link

Import db #26

Closed dmarin closed 9 years ago

dmarin commented 9 years ago

This is to import a database from a file

reisub commented 9 years ago

Hi @dmarin, thanks for taking the time to contribute new features!

The code looks good, you matched the style well. The only thing lint complains about is the name for the resource ic_file_download_white_24dp.png. It needs to start with dbinspector_ so we don't accidentally clash with resources in the rest of the project. Can you fix that?

More generally, the Travis build will fail if ./gradlew check fails so you can also run it locally if you don't want to wait for Travis.

reisub commented 9 years ago

Also, now that I think about it - that icon should probably be an icon pointing up as in upload, import. Down makes me thing download, export.

I merged in your other PR, #25. This PR seems to also be undoing some of the changes in the previous one. I'm not sure what happened there. Can you take a look? And maybe open a new one if you can't fix it in this one?

dmarin commented 9 years ago

Hi @reisub

Thanks, I did not know about the ./gradlew check. I have done a new commit with the requested changes. Thanks again for this library

reisub commented 9 years ago

Thanks!

reisub commented 9 years ago

This morning we released DbInspector 3.2.0 to maven which includes this feature. It might take a while for it to show up in search on maven central, but you can start using it within the hour.