search

infinum / android_dbinspector

Android library for viewing, editing and sharing in app databases.
Apache License 2.0
951 stars 91 forks source link

Build fail on some configurations in 5.2.2 #76

Closed jakoss closed 3 years ago

jakoss commented 3 years ago

:writing_hand: Describe the bug

I'm trying to assemble the apk with dbinspector, but i have issue with building it on GitHub Actions (ubuntu machine). I have this error

Execution failed for task ':app:processDebuggableDevDebugResources'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > Android resource linking failed
     /root/.gradle/caches/transforms-3/031c6876173f7b874f3236044a0b538f/transformed/jetified-dbinspector-5.2.2/res/mipmap-v26/dbinspector_launcher.xml:3: AAPT: error: resource drawable/dbinspector_launcher_background (aka com.ex.dev:drawable/dbinspector_launcher_background) not found.

     /root/.gradle/caches/transforms-3/031c6876173f7b874f3236044a0b538f/transformed/jetified-dbinspector-5.2.2/res/mipmap-v26/dbinspector_launcher.xml:4: AAPT: error: resource drawable/dbinspector_launcher_foreground (aka com.ex.dev:drawable/dbinspector_launcher_foreground) not found.

     /root/.gradle/caches/transforms-3/031c6876173f7b874f3236044a0b538f/transformed/jetified-dbinspector-5.2.2/res/mipmap-v26/dbinspector_launcher_round.xml:3: AAPT: error: resource drawable/dbinspector_launcher_background (aka com.ex.dev:drawable/dbinspector_launcher_background) not found.

     /root/.gradle/caches/transforms-3/031c6876173f7b874f3236044a0b538f/transformed/jetified-dbinspector-5.2.2/res/mipmap-v26/dbinspector_launcher_round.xml:4: AAPT: error: resource drawable/dbinspector_launcher_foreground (aka com.ex.dev:drawable/dbinspector_launcher_foreground) not found.

I do not have any issues building this on my dev windows machine. Do you have an idea why could that be?

Version 5.2.1 works perfectly fine

bojankoma commented 3 years ago

@jakoss I've moved the launcher icons from drawable to mipmap folders. I should have mentioned that as a breaking change. If this is the case, you have to change the reference from drawable/dbinspector_launcher_foreground to mipmap/dbinspector_launcher_foreground.

I'll also run some manual tests with this change myself and get back to you here.

bojankoma commented 3 years ago

Can confirm this is a bug. Please stand by for a fix.