search

infinum / datx

DatX is an opinionated JS/TS data store. It features support for simple property definition, references to other models and first-class TypeScript support.
https://datx.dev
MIT License
139 stars 7 forks source link

Project setup issues due to a different global lerna version #1207

Open fvoska opened 9 months ago

fvoska commented 9 months ago

Used libraries

all

Library version(s)

all

Environments with the issue

Node 18

Current behavior

Currently, the latest lerna version is 8.0.0. Version installed in the repository is 6.6.2 - 2 versions behind. CONTRIBUTING.md instructions say you should install lerna globally. However, that will install 8.0.0 globally and running commands like lerna run build does not work:

image

Seems like there was some breaking change in lerna v7 or v8.

Using the locally installed version works:

image

Expected behavior

We should not rely on contributors installing lerna globally because we can not ensure which version they will install. Even if we update the readme to tell contributors to install some specific version globally, that might be in conflict with other project for which they might need to use a different version (and you can only install one version globally).

All tooling should be invoked via npm scripts and use locally installed versions of packages. Readme and contribution documents should reflect this.

Reproduction steps

Clone the project anew and follow CONTRIBUTING.md guidelines for project setup