Use image-webpack-loader instead of `file-loader` for images?

dingo-d commented 6 years ago

The image-webpack-loader will optimize images, should we use it instead of file-loader?

{
  test: /\.(png|svg|jpg|jpeg|gif|ico)$/,
  exclude: [/fonts/, /node_modules/],
  use: `file-loader?name=${outputImages}`,
}

?

iruzevic commented 6 years ago

there have been issues with https://github.com/tcoopman/image-webpack-loader in the past.

This loader has not been updated for several months, and the banner states that it is out of date.

we should check it out. Maybe version 3.1

dingo-d commented 6 years ago

Wasn't aware of the issues. I agree with pushing this back to later version :+1:

MetarDev commented 4 years ago

@dingo-d @iruzevic Is this still relevant?

Personally I think it's not worth it (we should be loading most of our images through WordPress's media library anyway, the few that we're loading as static assets can be optimized manually if needed).

Also https://github.com/tcoopman/image-webpack-loader is reporting issues on some Mac versions when you don't have some library installed, I'd rather if we not add a new potential fail-point during setup for, what I believe is, almost no added benefit.

iruzevic commented 4 years ago

Agreed you can close this

On Wed, 18 Mar 2020, 08:51 Ivan Grginov, notifications@github.com wrote:

@dingo-d https://github.com/dingo-d @iruzevic https://github.com/iruzevic Is this still relevant?

Personally I think it's not worth it (we should be loading most of our images through WordPress's media library anyway, the few that we're loading as static assets can be optimized manually if needed).

Also https://github.com/tcoopman/image-webpack-loader is reporting issues on some Mac versions when you don't have some library installed, I'd rather if we not add a new potential fail-point during setup for, what I believe is, almost no added benefit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/infinum/eightshift-boilerplate/issues/104#issuecomment-600474302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRUM7DDSIMUTXYW4LUT7ITRIB4RPANCNFSM4FSN4HYQ .

infinum / eightshift-boilerplate

Use image-webpack-loader instead of `file-loader` for images? #104