infinum / eightshift-boilerplate

This repository contains all the tools you need to start building a modern WordPress theme, using all the latest front end development tools.
https://eightshift.com
MIT License
543 stars 69 forks source link

Plugin installation leaves the main file name eightshift-boilerplate.php #200

Closed dingo-d closed 4 years ago

dingo-d commented 4 years ago

It seems that when you run npx create-wp-project plugin the rename script is not changing the main entrypoint file, or contents of the docblock.

In my plugin I have eightshift-boilerplate.php with

<?php
/**
 * Plugin Name: Eightshift Boilerplate Title
 * Plugin URI:
 * Description: Eightshift Boilerplate Description
 * Author: Team Eightshift
 * Author URI: https://eightshift.com/
 * Version: 1.0.0
 * Text Domain: this-is-correctly-changed
 *
 * @package This_Is_Correctly_Changed
 *
 * @since 1.0.0
 */
MetarDev commented 4 years ago

Good catch, this is because we haven't tweaked the setup script for plugins, it's looking for Theme name: Something to replace. I just need to tweak the rename function.

Also, it might make more sense to put issues like these (related to setup) in https://github.com/infinum/eightshift-frontend-libs (where setup script lives).

dingo-d commented 4 years ago

Wasn't aware of this, kinda hard to keep track of where everything is 😬 I'll open an issue upstream.