search

infinum / eightshift-frontend-libs

Frontend library that exposes custom scripts and styles for modern WordPress projects
https://eightshift.com
MIT License
71 stars 12 forks source link

[BUG] package.json and composer.json contain default lib data #398

Closed dingo-d closed 4 months ago

dingo-d commented 3 years ago

Another thing I noticed when you set up a project, the default package.json and composer.json that get copied over will contain all the data from the libs, i.e. the name will be prefixed with eightshift and the github URLs will also contain the eightshift repo url.

The problem with that is, if somebody uses the libs to publish something on npm/packagist, there could be some issues present.

We should either set up some minimum examples, or replace these things while copying the project using the script.

iruzevic commented 3 years ago

They cant publish anything to the npm or packagist because only we have write and publish rights. But we can update this why not

dingo-d commented 3 years ago

Yeah, this is more if they use our BP for their plugin that they wish to push to packagist or npm or something like this.

iruzevic commented 3 years ago

sure we can make this work, this needs to be updated in the https://github.com/infinum/eightshift-frontend-libs/tree/develop/setup/create-wp-project part

iruzevic commented 4 months ago

this is done in the latest release