infinum / eightshift-frontend-libs

Frontend library that exposes custom scripts and styles for modern WordPress projects
https://eightshift.com
MIT License
71 stars 12 forks source link

Make installation available from other branches than the Infinum repo #824

Closed DjidjaleskaSandra closed 6 months ago

DjidjaleskaSandra commented 7 months ago

Description

This PR introduces functionality that enables users to specify custom repository URLs for Composer dependencies directly via command line arguments. This enhancement provides greater flexibility and control over dependency management, particularly useful for testing different branches or forks of libraries during development.

Productive ticket

https://app.productive.io/1-infinum/tasks/7821114

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.04%. Comparing base (d0906ed) to head (4a7d4da). Report is 14 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #824 +/- ## ======================================== Coverage 25.04% 25.04% ======================================== Files 36 36 Lines 1206 1206 Branches 305 305 ======================================== Hits 302 302 Misses 631 631 Partials 273 273 ``` | [Flag](https://app.codecov.io/gh/infinum/eightshift-frontend-libs/pull/824/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infinum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/infinum/eightshift-frontend-libs/pull/824/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infinum) | `25.04% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infinum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iruzevic commented 7 months ago

Looks ok, but why not add frontend libs and boilerplate repos flags also?

DjidjaleskaSandra commented 6 months ago

Looks ok, but why not add frontend libs and boilerplate repos flags also?

Bolilerplate repo -flag exist, I added for frontend libs only

iruzevic commented 6 months ago

I have changed the new setup full so the part of these changes are there I will not be merging the PR but tnx