infinum / eightshift-libs

Library that is meant to be used inside Eightshift Boilerplate and Eightshift Boilerplate Plugin libs via composer in order to be able to easily set up a modern development process.
https://eightshift.com
MIT License
62 stars 11 forks source link

[BUG] - Redeploy doesn't change theme version and resets cache #430

Closed dadadavorin closed 1 month ago

dadadavorin commented 2 months ago

When running the same deploy process again, the theme version in style.css stays the same, which in turn does not reset cache and causes some functionalities to break.

In my example, applicationBlocksEditor files were not loading correctly due to cache not being reset after running deploy.

I can see that setup-version-theme action gets the key from VERSION=${{ github.sha }}, and github.sha refers to the last commit - and if we're running same commit again this key is the same.

This seems to be the issue, since manually changing the theme version in style.css also solves the caching issue.

iruzevic commented 1 month ago

This should be fixed