search

infinum / ios-sentinel

Developer’s toolbox for debugging applications
Apache License 2.0
4 stars 1 forks source link

[Feature] Preferences: New Input Types #27

Open manuelvrhovac opened 11 months ago

manuelvrhovac commented 11 months ago

Background

We use Sentinel a lot in our project and having a toggle that the QA team (or us devs) can use to test different scenarios in the app has helped us immensely! E.g. Instead of creating several different builds with various configurations, one DEV build with some sentinel toggles was all we needed.

Motivation

However it was limited to only a Boolean input yet I wanted QA and devs to be able to change more parameters like URLs, some time intervals, and just various cases/enums in general during the runtime.

For this reason we've decided it was worth some time to expand the Preferences feature of Sentinel! 🎉

Information

More data types are now available as Preferences: String, Integer, Double, and Enums:

Simulator Screenshot - iPhoSE3_164 - 2023-09-12 at 11 35 03

Please let me know what you think! ✨

manuelvrhovac commented 11 months ago

@nikolamajcen the Bitrise check seems to be failing due to "Xcode test for iOS (Failed)" yet I don't see any tests in this repository? What gives?

nikolamajcen commented 11 months ago

@goranbrl with the current changes, as I can see, we can still use the same code for boolean values. So, with that in mind, I would go with 1.2.0.

But, based on the changes that I've proposed, that could change a bit, and changes would be required for value initialization (not backward compatible). If that happens, the change should require a new major version, and that could be 2.0.0 - based on semantic versioning.

nikolamajcen commented 11 months ago

Hey @manuelvrhovac, there are test targets, but that was not the issue. In short, I've fixed the CI, and it works as expected now 😉