search

infinyon / fluvio-client-node

Node.js client for Fluvio
https://infinyon.github.io/fluvio-client-node/
Apache License 2.0
9 stars 10 forks source link

Fix compilation for node 18 #288

Closed morenol closed 1 year ago

morenol commented 1 year ago

error is on node >= 18.14

drc-infinyon commented 1 year ago

@morenol - Is this issue related to https://discord.com/channels/695712741381636168/798603561239183481/1098594895666614313

morenol commented 1 year ago

It is partially related, most of the PRs like https://github.com/infinyon/fluvio-client-node/pull/286 are blocked because CI is broken for node 18

drc-infinyon commented 1 year ago

Okay. Got it. Was there any discussion or plan recently on what we are going to do about the broken CI?

digikata commented 1 year ago

I think the issue here is that compilation works, but the tests fail on versions of node 18.14+ as well as the current node 20

digikata commented 1 year ago

may be related to https://github.com/infinyon/node-bindgen/issues/234 (which contains a case that is ok on node 18, but fails on 20) but the errors land a bit differently than the fluvio-client-node failures, so it's not fully clear if it's related or independent.

morenol commented 1 year ago

Fixed with node-bindgen update