search

infinyon / fluvio-client-python

The Fluvio Python Client!
https://infinyon.github.io/fluvio-client-python/fluvio.html
Apache License 2.0
14 stars 12 forks source link

Feature/admin #375

Closed Shylock-Hg closed 8 months ago

Shylock-Hg commented 8 months ago

Close #367 Close https://github.com/infinyon/fluvio/issues/3859 /claim https://github.com/infinyon/fluvio/issues/3859

digikata commented 8 months ago

Hi @Shylock-Hg, its great to see progress getting closer, though re: the bounty claim, I think we need to have the existing tests pass as well as test coverage for the new capability in admin and async.

I know ghub was having some issues fri, so I'll rerun some of these tests too and check on some of the macos failures to see if it's something shifted in the CI independent of your PRs.

digikata commented 8 months ago

@Shylock-Hg can you rebase? There is a fix for the macos build CI. Some upstream config was breaking the build. This should let us test with the full CI.

https://github.com/infinyon/fluvio-client-python/pull/377 I rebased your your async branch and reopened a draft pr to check it too.

Shylock-Hg commented 8 months ago

@Shylock-Hg can you rebase? There is a fix for the macos build CI. Some upstream config was breaking the build. This should let us test with the full CI.

377 I rebased your your async branch and reopened a draft pr to check it too.

Ok.

digikata commented 8 months ago

Hi @Shylock-Hg, we released fluvio 0.11.5 with your upstreamed changes in it for the python client. I rebased both your PRs and did some selected merging to update the references. There are just some cargo clippy issues to take care of. I don't know the easiest way for you to claim it, but maybe pull the branch https://github.com/infinyon/fluvio-client-python/tree/pre-0.17.0, do the cleanup and claim on that result?

We are asking some of our expert fluvio python client users to take a look at that branch with your work in it too.

Shylock-Hg commented 8 months ago

Hi @Shylock-Hg, we released fluvio 0.11.5 with your upstreamed changes in it for the python client. I rebased both your PRs and did some selected merging to update the references. There are just some cargo clippy issues to take care of. I don't know the easiest way for you to claim it, but maybe pull the branch https://github.com/infinyon/fluvio-client-python/tree/pre-0.17.0, do the cleanup and claim on that result?

We are asking some of our expert fluvio python client users to take a look at that branch with your work in it too.

Hello, I request a PR to shylock/feature/async to fix clippy issues of it, and fix clippy issues here of this PR. Is it ok?

digikata commented 8 months ago

@Shylock-Hg Thanks for the async updates, I checked the async PR, made some very minor cargo fmt fixes and merged it, so t he only thing we need to worry about is rebaseng this pr, maybe some clippy fixes, and input from our two heavy python users.

Shylock-Hg commented 8 months ago

@Shylock-Hg Thanks for the async updates, I checked the async PR, made some very minor cargo fmt fixes and merged it, so t he only thing we need to worry about is rebaseng this pr, maybe some clippy fixes, and input from our two heavy python users.

It's done.

digikata commented 8 months ago

@Shylock-Hg If you could rebase onto main, I think we are ready to merge and sign off on the bounty (cc: @drc-infinyon )

Shylock-Hg commented 8 months ago

@Shylock-Hg If you could rebase onto main, I think we are ready to merge and sign off on the bounty (cc: @drc-infinyon )

Ok, it's done.

digikata commented 8 months ago

Thanks @Shylock-Hg !

drc-infinyon commented 8 months ago

@Shylock-Hg - This ticket is resolved.

You need to claim the bounty based on this workflow: https://docs.algora.io/bounties/workflow -

To claim a bounty on Github, navigate to your pull request that solves the bountied issue and add /claim <ISSUE_NUMBER> somewhere in the body of the PR.