bug: different default SPU port

infinyon / fluvio

Lean and mean distributed stream processing system written in rust and web assembly. Alternative to Kafka + Flink in one.

https://www.fluvio.io/

Apache License 2.0

3.88k stars 491 forks source link

bug: different default SPU port #3739

Open sehz opened 11 months ago

sehz commented 11 months ago

Cluster start use different port than default port. Cluster: https://github.com/infinyon/fluvio/blob/master/crates/fluvio-cluster/src/runtime/local/spu.rs.
Default: https://github.com/infinyon/fluvio/blob/master/crates/fluvio-types/src/defaults.rs.

So when starting in cluster command:

$ fluvio cluster start

starts in different default port (9010)

than directly starting SPU directly

fluvio-run spu -i 5001 --log-base-dir /fluvio/data

which defaults to 9005

Suggestion solution:

change default to 9010
use cluster command to use defaults

ajhunyady commented 11 months ago

It makes me wonder why the port is not read from defaults.rs, so we have a single source of truth.

AnthonyMBonafide commented 10 months ago

I attempted a fix in PR #3815 .

github-actions[bot] commented 8 months ago

Stale issue message

AnthonyMBonafide commented 1 week ago

Hey Fluvio team! I am looking to take this back on. I have some free time coming up and looking to start contributing again. I can reopen my PR and start working on this again in the next couple of days. I was able to rebase it with the latest changes.

Would it be possible to re-open PR #3815 or should I start a new PR?

ajhunyady commented 1 week ago

@AnthonyMBonafide, welcome back. @digikata can guide you on which direction to take.