search

infinyon / fluvio

Lean and mean distributed stream processing system written in rust and web assembly. Alternative to Kafka + Flink in one.
https://www.fluvio.io/
Apache License 2.0
3.79k stars 500 forks source link

feat(smdk): add smdk clean #4108

Closed diogopontual closed 2 months ago

diogopontual commented 2 months ago

I'm trying to learn the fluvio code.

I got the first "good first issue" on the list.

Fixes #3985

diogopontual commented 2 months ago

Hi @EstebanBorai. I just noticed there is a problem with the PR. Do you have any clue how I can fix it? TY.

EstebanBorai commented 2 months ago

Hi @EstebanBorai. I just noticed there is a problem with the PR. Do you have any clue how I can fix it? TY.

Sure thing!

EstebanBorai commented 2 months ago

Hi @diogopontual, seems like the issue with CI is not related to your code, but to other component in our system called FVM.

fraidev commented 2 months ago

Hi @EstebanBorai. I just noticed there is a problem with the PR. Do you have any clue how I can fix it? TY.

I believe that rebasing master should fix it

digikata commented 2 months ago

The previous failures were, I think from a github outage, re-running gives an error on fvm, but that is likely because we are about to do a release and this branch needs a rebase. I'm hitting update on a rebase and we'll see if it's clean.

EstebanBorai commented 2 months ago

Hi @diogopontual!

Seems like we need to run cargo fmt on this repo to fix code formatting issues!

EstebanBorai commented 2 months ago

Hi @diogopontual! Can you please rebase to have Rust 1.80 updates applied please?

EstebanBorai commented 2 months ago

Great progress @diogopontual! I think we are just missing smoke tests for this feature and we are good to go!

diogopontual commented 2 months ago

Wow. is that a green mark? God is good!

I will work on the smoke test this weekend. The week was full. TY.

EstebanBorai commented 2 months ago

Wow. is that a green mark? God is good! 😂

I will work on the smoke test this weekend. The week was full. TY. Great! Ask any questions!

diogopontual commented 2 months ago

Hey @EstebanBorai, I did create the test as you described. TY.

EstebanBorai commented 2 months ago

Hey @EstebanBorai, I did create the test as you described. TY.

Thanks to you!

EstebanBorai commented 2 months ago

@diogopontual I have updated the PR title to make it match conventional commits!