Closed nicholastmosher closed 2 years ago
1) mixes implementation and behavior. My feedback is on behavior. We should have a consistent profile view
that shows the profile in a table format. One way to solve the certificate issue is to display in details
command.
Stale issue message
We no longer have fluvio profile view
Currently, executing
fluvio profile view
may be very noisy because any inline TLS certificates are printed directly to the screen, resulting in large base64 blobs of text that fill up the screen and make things hard to read. The ultimate goal of this issue is to improve readability offluvio profile view
.I see two action items which we may take to improve this. We can do one or both of these to improve readability.
1) We could override the implementation of the
Debug
orDisplay
trait of the config object so that any inline TLS certificates are simply omitted or truncated, e.g.<hidden>
.2) We could make all client code use path-based TLS certs rather than inline certs by convention. Here are the pros and cons I see:
kubectl config view
shows paths to TLS certs rather than printing them inline.fluvio cloud login
, we need a strategy for writing the TLS certs to a place where they are uniquely discoverable for that profile.I think we should apply both of these actions. We don't need to do them all at once or anything but let's discuss.
After some discussion, we have decided to pursue 1) as the action item for this issue. If we decide it is necessary in the future, we may revisit point 2).
Action item:
Display
andDebug
to print inline TLS as<hidden>
.