infinyon / fluvio

Lean and mean distributed stream processing system written in rust and web assembly. Alternative to Kafka + Flink in one.
https://www.fluvio.io/
Apache License 2.0
3.88k stars 491 forks source link

CLI: `fluvio profile view` should not print TLS certificates to screen #609

Closed nicholastmosher closed 2 years ago

nicholastmosher commented 3 years ago

Currently, executing fluvio profile view may be very noisy because any inline TLS certificates are printed directly to the screen, resulting in large base64 blobs of text that fill up the screen and make things hard to read. The ultimate goal of this issue is to improve readability of fluvio profile view.

I see two action items which we may take to improve this. We can do one or both of these to improve readability.

1) We could override the implementation of the Debug or Display trait of the config object so that any inline TLS certificates are simply omitted or truncated, e.g. <hidden>.

2) We could make all client code use path-based TLS certs rather than inline certs by convention. Here are the pros and cons I see:

I think we should apply both of these actions. We don't need to do them all at once or anything but let's discuss.


After some discussion, we have decided to pursue 1) as the action item for this issue. If we decide it is necessary in the future, we may revisit point 2).

Action item:

ajhunyady commented 3 years ago

1) mixes implementation and behavior. My feedback is on behavior. We should have a consistent profile view that shows the profile in a table format. One way to solve the certificate issue is to display in details command.

github-actions[bot] commented 3 years ago

Stale issue message

nacardin commented 2 years ago

We no longer have fluvio profile view