infinyon / future-aio

Advanced futures library
Apache License 2.0
16 stars 17 forks source link

chore: update deps #265

Closed nacardin closed 3 months ago

nacardin commented 4 months ago

Includes https://github.com/infinyon/future-aio/pull/241 and https://github.com/infinyon/future-aio/pull/258

Resolves https://github.com/infinyon/future-aio/issues/239

morenol commented 4 months ago

@nacardin maybe this PR could be helpful https://github.com/infinyon/future-aio/pull/258

nacardin commented 4 months ago

@nacardin maybe this PR could be helpful #258

That seems to change behavior to only fire once. I made a change to preserve existing behavior of firing the timer for every await of the future.

@morenol I just noticed that you tried a similar change in the PR, why did you revert it?

morenol commented 4 months ago

I reverted it because @sehz mentioned me that it should only fire once:

https://github.com/infinyon/future-aio/pull/258#discussion_r1595669083

Not sure if fluvio or any other crate relies on that multiple fires behavior by the timer

nacardin commented 4 months ago

@sehz We should also convert native_tls and openssl_tls errors to anyhow?