infinyon / k8-api

Native Rust implementation of Kubernetes api
Apache License 2.0
35 stars 17 forks source link

support native-tls driver #21

Closed sehz closed 4 years ago

nicholastmosher commented 4 years ago

Here's what I've found after some research on this:

sehz commented 4 years ago

It is using rustls . However, we do want to preserve that capability. In order to do so we can put that under feature gate.

sehz commented 4 years ago

reason isahc was used because it had good integration with rustls. For native-tls, we could consider switch to hyper has good support

nicholastmosher commented 4 years ago

Right now I've been able to remove curl, openssl-sys, webpki, rustls, and fluvio-future from the dependencies of k8-client and continue building and testing successfully, even with --all-features and --all-targets. Right now the hyper module is broken (i.e. re-enabling it immediately causes a build break) so it's hard to determine which dependencies would need to stick around and how to put them into feature flags. I think we should just remove the unused dependencies for now and add them back as needed in the future if and when we want hyper support.

sehz commented 4 years ago

put hyper in the separate feature flag since it wasn't working previously

sehz commented 4 years ago

Done. Added feature flag for both rustls and native_tls. Use Hyper for Http Client