search

infinyon / node-bindgen

Easy way to write Node.js module using Rust
Apache License 2.0
531 stars 44 forks source link

[Merged by Bors] - fix: misalignment crash #259

Closed sehz closed 1 year ago

sehz commented 1 year ago

resolves #255

The underlying issue was that the reference to wrap was removed just after the constructor was called. The code was there probably due to a workaround bug in the previous version of node.

May need to clean up reference to wrap when finalizer is invoked

sehz commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build failed:

sehz commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.