infinyon / node-bindgen

Easy way to write Node.js module using Rust
Apache License 2.0
507 stars 43 forks source link

New Release to crates.io Compatible with Rust 1.79 #296

Closed AmmarAbouZor closed 2 months ago

AmmarAbouZor commented 2 months ago

Hello,

I've been using your crate and appreciate all the work that has gone into it. I recently updated to Rust 1.79 and since then building Node.js modules with the command nj-cli build --release with the nj-cli tool installed from crates.io fails with the error:

no cdylib target was founded

However, when I build the CLI tool directly from the GitHub master, it works fine. Therefore, I would appreciate it if you release a new version to crates.io since the current version there isn't compatible with Rust 1.79 anymore.

sehz commented 2 months ago

Sure. @morenol can you do release?

morenol commented 2 months ago

Released a new version of nj-cli

@AmmarAbouZor Feel free to reopen this or create a new issue if you find any issue with the new version

AmmarAbouZor commented 2 months ago

Very thanks for your quick response. Everything is working great as expected again :100: