search

inflatablefriends / lastfm

Portable .Net library for Last.fm
Other
100 stars 61 forks source link

Fixed: Nuget Package Build, Artifacts #112

Closed Qstick closed 6 years ago

Qstick commented 6 years ago

Fixes #107

rikkit commented 6 years ago

Hi @Qstick thank you so much for the PR! I am not in the .Net world much right now, so I am glad the existing build process an be made to work with Nuget 3.

I noticed this message in the build logs:

WARNING: 1 issue(s) found with package 'Inflatable.Lastfm'.
Issue: Invalid framework folder.
Description: The folder 'netstandard1.1' under 'lib' is not recognized as a valid framework name or a supported culture identifier.

From a quick search it seems like the Appveyor config needs to be updated in some way. Have you tried using the package generated by the CI build in a project? Just wondering if the message is a problem or not.

Qstick commented 6 years ago

I have not tried to use in a project yet, let me investigate the test further tonight.

Qstick commented 6 years ago

@rikkit seems the version of nuget you had packaged with lastfm was pre-3.0. Updated the packaged version to 3.5.0 which recognizes netstandard1.1 as a valid target framework (https://docs.microsoft.com/en-us/nuget/reference/target-frameworks) did the trick.

On another note you have the SQLite package setup to go into a lib\portable-win8+net45+wp8+wpa81 directory in the nuget package, should this also be netstandard1.1?

rikkit commented 6 years ago

Thanks @Qstick! On the SQLite package, yeah it should - but need to check whether sqlite-net-pcl has a netstandard package now. If I remember right it didn't at the time I originally set up netstandard.