search

inflatablefriends / lastfm

Portable .Net library for Last.fm
Other
100 stars 61 forks source link

Issue 128 - Artist.GetInfoCommand - added lang parameter #138

Closed klinge closed 5 years ago

klinge commented 5 years ago

Fixed a bug from issue #128. Verified it is working - but did not make any tests because I changed most of the unit tests files in another PR and did not want to make the merge unneccessarily complicated.

rikkit commented 5 years ago

Hi @klinge - I've finally merged #136. Would you mind adding a test here?

klinge commented 5 years ago

Will do! When is the SetParameters method in the command called? Tried testing for values in the command Parameter dictionary in a unit test but it seems it is still empty..

rikkit commented 5 years ago

It's called as part of making the request (.ExecuteAsync())

klinge commented 5 years ago

Messed up local branches - will create a new PR that includes some unit tests