search

inflatablefriends / lastfm

Portable .Net library for Last.fm
Other
100 stars 61 forks source link

Add LastResponseStatus for Login Required #150

Closed th0mk closed 4 years ago

th0mk commented 4 years ago

When a users profile is private, a request like User.getRecentTracks can return error 17:

{
    "error": 17,
    "message": "Login: User required to be logged in"
}

This error code does not exist in the LastResponseStatus enum.

rikkit commented 4 years ago

Hi @th0mk, thanks for this report. I don't currently have time to do much work on this library, so if you can send a PR that'd be great! IIRC the value just needs adding here: https://github.com/inflatablefriends/lastfm/blob/master/src/IF.Lastfm.Core/Api/Enums/LastResponseStatus.cs

th0mk commented 4 years ago

Thanks, I will do a PR today. Note: this response isn't mentioned anywhere in the Last.FM docs, but they're pretty outdated anyways..

th0mk commented 4 years ago

Hi there, do you maybe have some time to look at my PR?