Closed Sarsoo closed 1 year ago
Hey @Sarsoo . changes look fine, thanks!. But I need to figure out why checks aren't running on this branch. Any ideas?
That's odd, I had assumed it was a security thing because I changed the actions. When I Google it, branch protection rules seem to keep coming up, community thread, docs
Have looked a bit into it, I think you may need to go to your fork of this repo and enable actions on it. Then you may need to push again to this branch to trigger the action... 🤔
I have actions enabled on my fork. On checking, however I did notice this setting
With a link to this bit of the docs which suggests that first time collaborators need approval. I can try pushing a dummy commit to see if it'll get it moving, presumably there's no button to approve the actions on the PR from your side?
This is what I see
Yeah I was wondering about the Actions config. The workflow is only set to run on push
. I'm not sure what that should be changed to in order to run when a PR is opened from a forked repo. Can you try pushing that dummy commit?
Cheers
Coming back to this, I was hoping to see if we could move this forward. The blocker currently is the CI not running so I'm going to close this PR and open a new one to see if that can jump start it
Fixed the integration tests and tested the other projects. Will follow this by repushing the #167 to retest