search

inflatablefriends / lastfm

Portable .Net library for Last.fm
Other
100 stars 62 forks source link

Fixed integration tests, bumped test projects up to .NET 6 #169

Closed Sarsoo closed 1 year ago

Sarsoo commented 2 years ago

Fixed the integration tests and tested the other projects. Will follow this by repushing the #167 to retest

rikkit commented 2 years ago

Hey @Sarsoo . changes look fine, thanks!. But I need to figure out why checks aren't running on this branch. Any ideas?

Sarsoo commented 2 years ago

That's odd, I had assumed it was a security thing because I changed the actions. When I Google it, branch protection rules seem to keep coming up, community thread, docs

rikkit commented 2 years ago

Have looked a bit into it, I think you may need to go to your fork of this repo and enable actions on it. Then you may need to push again to this branch to trigger the action... 🤔

Sarsoo commented 2 years ago

I have actions enabled on my fork. On checking, however I did notice this setting

image

With a link to this bit of the docs which suggests that first time collaborators need approval. I can try pushing a dummy commit to see if it'll get it moving, presumably there's no button to approve the actions on the PR from your side?

rikkit commented 2 years ago

This is what I see

image

Yeah I was wondering about the Actions config. The workflow is only set to run on push. I'm not sure what that should be changed to in order to run when a PR is opened from a forked repo. Can you try pushing that dummy commit?

Cheers

Sarsoo commented 1 year ago

Coming back to this, I was hoping to see if we could move this forward. The blocker currently is the CI not running so I'm going to close this PR and open a new one to see if that can jump start it