search

inflation / jpegxl-rs

GNU General Public License v3.0
62 stars 12 forks source link

Explicitly configure libdir to lib #39

Closed Szpadel closed 5 months ago

Szpadel commented 8 months ago

Without this setting static library is placed in lib or lib64 depending on platform

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.18%. Comparing base (4a36ba0) to head (982a540).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #39 +/- ## ======================================= Coverage 99.18% 99.18% ======================================= Files 12 12 Lines 854 854 ======================================= Hits 847 847 Misses 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

inflation commented 8 months ago

I guess I shouldn't hardcode the library path, since the user could modify it by env as well. Perhaps reading from the generated pkg-config?

Szpadel commented 7 months ago

Also sounds like solution. I'm not familiar with enough with pkg-config and cmake configurations, therefore I failed to influence that from env. For me any way that would make this reliable is good. I found that linux defaults to lib64 and macos to lib therefore if you want to test that locally (I'm assuming you use macos from hardcoded path) docker should be easiest way

inflation commented 5 months ago

Integrated in #46. Thanks.