influitive / apartment-sidekiq

Sidekiq support for the Apartment Gem
MIT License
126 stars 54 forks source link

Rails 5.0 incompatibilities #12

Open mensfeld opened 8 years ago

mensfeld commented 8 years ago

Apartment sidekiq is no longer working out of the box with the new Rails.

In order to make it work I had to manually invoke:

require 'apartment/sidekiq/railtie'
Apartment::Sidekiq::Middleware.run
arwaahmed commented 7 years ago

@mensfeld Facing the same issue here, i placed your snippet in an initalizer and it is still not working. Any hints?

mensfeld commented 7 years ago

@arwaahmed unfortunately I decided not to go with Apartment as in the end I had to start doing multiple hacks to make it work. Until it is supported I would not recommend using Apartment with Rails5.

jhubert commented 7 years ago

@mensfeld What did you use instead?

jhubert commented 7 years ago

@bradrobertson Are you aware of this? Anything we can do to help?

mensfeld commented 7 years ago

@jhubert I decided to go a different road ;)

hcurotta commented 5 years ago

Hi there. Are we likely to see Rails 5 supported?

I've taken the approach linked in one of the other threads, passing the tenant to the jobs explicitly, but gems like SearchKick queue up jobs automatically and I can't cleanly wedge the tenant name into the callback.

Would be great to know if there are any other recommended approaches. Cheers!