Closed shterrett closed 6 years ago
I'm using this fork in production. It works! Hurray!
Me too! I hope it can be reviewed soon.
I’ll review this ASAP.
@shterrett Would you please write some tests?
@meganemura I'd be happy to - I'm not sure where though. I think this is covered by the "create a new tenant" tests which were failing under the postgres version I was running. Can you point me in the right direction?
Also, I don't know why the Jenkins build failed. The errors have to do with database creation; the commit I pushed this morning simply added some comments to the config/initializers/apartment.rb
template.
I think this build failure is related to the release of mysql2 0.5.0 gem. See this note. I'll pin it in the gemfiles/* soon.
Thanks @shterrett, @cyrill62 (for #536) and @aldrinmartoq (for reporting #532).
Address https://github.com/influitive/apartment/issues/532 for Postgres 10.3. See https://github.com/influitive/apartment/pull/536 for more details.
I was trying to run only the postgres tests locally and was having some trouble with some where the
Apartment.connection.schema_search_path = <search_path>
call didn't actually have an effect on the database. I'm curious to see if the tests pass on CI, or if there's another issue with my environment.