search

influitive / apartment

Database multi-tenancy for Rack (and Rails) applications
2.67k stars 463 forks source link

Fix compatibility with Rails 3 #558

Closed btagliani closed 5 years ago

btagliani commented 6 years ago

Since ActiveRecord.version was added in Rails 4, it causes a NoMethodError in Rails 3 and under. This is a small fix to prevent that from happening and retain the method's logic value.

btagliani commented 6 years ago

I just saw https://github.com/influitive/apartment/pull/557, talk about timing 😄. That PR doesnt change the Rakefile though.

btagliani commented 6 years ago

Hi guys! this fix allows us (and everyone on Rails 3) to use the latest version of apartment, so I'd be awesome if someone could review it. Thanks!

mikecmpbll commented 5 years ago

we don't support rails 3 anymore i'm afraid. we've dropped it from our travis testing. i don't want to send the wrong message by merging rails 3 related stuff 💔