fix(ui): optimize dropdown menu to avoid items re-rendering

influxdata / chronograf

Open source monitoring and visualization UI for the TICK stack

https://www.influxdata.com/time-series-platform/chronograf/

Other

1.5k stars 257 forks source link

fix(ui): optimize dropdown menu to avoid items re-rendering #5957

Closed sranka closed 2 years ago

sranka commented 2 years ago

This PR fixes the dropdown menu so that

page URL is not changed on item click
highlighted only opened dropdown
rely upon CSS :hover highlighting unless using Dropdown in auto-complete mode

Especially the latter is an optimization that is required to stabilize Cypress tests. Before this PR, chronograf administration dropdown menus were magically replaced in DOM before with the first highlight in the menu.

[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass

sranka commented 2 years ago

@k3yi0 I tested this through code debugging, DOM replacements of administration dropdown menus no longer occur after this PR, clickAttached in cypress tests can be avoided.