influxdata / chronograf

Open source monitoring and visualization UI for the TICK stack
https://www.influxdata.com/time-series-platform/chronograf/
Other
1.5k stars 257 forks source link

fix(ui): repair rendering of AllUsersTableRow #5979

Closed sranka closed 2 years ago

sranka commented 2 years ago

Closes #5978

Briefly describe your proposed changes: The table row re-renders upon any change of the user structure.

What was the problem? The row did not re-render when user's superAdmin status changed. It was caused by some relict from the past, which excluded superAdmin status from re-rendering. The rows were however completely replaced upon any change in 1.9.4, the buggy code was thus never effective. Cypress tests were hard to do with frequent useless replacements of rows in DOM. #5947 fixed it and ensured that row DOM elements are updated upon changes. As a side-effect, the forgotten wrong behavior of optimized row rendering becomes effective.

What was the solution? Re-rerender row on change of the user, including superAdmin status.