influxdata / chronograf

Open source monitoring and visualization UI for the TICK stack
https://www.influxdata.com/time-series-platform/chronograf/
Other
1.5k stars 258 forks source link

fix: avoid error on typing colon #6056

Closed R290 closed 1 year ago

R290 commented 1 year ago

Closes #6007 Closes #6009 Closes #6011 Closes #6013 Closes #6017 Closes #6031 Closes #6034 Closes #6037 Closes #6038 Closes #6039 Closes #6044 Closes #6048 Closes #6051 Closes #6052 Closes #6053 Closes #6055 I might have missed a few issues describing the same error.

Briefly describe your proposed changes:

Replace FunctionComponent by Component in the TemplateDrawer to restore compatibility with react-onclickoutside

What was the problem?

Error when typing a colon: Cannot read properties of undefined (reading 'getInstance')

What was the solution?

Replacing FunctionComponent by Component, setting properties and adding a render function.

R290 commented 1 year ago

@jdstrand @jeffreyssmith2nd @ivankudibal @bnpfeife does anybody have the opportunity to review?

Sciator commented 1 year ago

It would be good to add @types/react-onclickoutside to devDependencies also.

R290 commented 1 year ago

Thanks to both of you for your review. I hope we can merge and release soon, the colon error is causing quite a lot of issues being created.

R290 commented 1 year ago

Another issue has popped up (#6058), time to merge this? @ivankudibal @Sciator