fix: MenuDropdown fixes - Githubissues

influxdata / clockface

UI Kit for building Chronograf

https://influxdata.github.io/clockface

MIT License

44 stars 18 forks source link

fix: MenuDropdown fixes #786

Closed ChitlangeSahas closed 2 years ago

ChitlangeSahas commented 2 years ago

Closes https://github.com/influxdata/clockface/issues/787

Changes

Added an onSelectOption handler which sends the information back to the UI when an option is selected.
Adds the checkmark instead of the blue background for the selected option.
When dropdown typeahead was cleared it cleared the state of the whole component, this is undesirable.
Some styling changes to make it match the figma design.

Screenshots

https://user-images.githubusercontent.com/18511823/175786985-be13c653-cdf3-4fb3-af10-afe046cefa7b.mov

// Add screenshots here if relevant

Checklist

Check all that apply

[x] Updated documentation to reflect changes
[x] Added entry to top of Changelog with link to PR (not issue)
[x] Tests pass
[ ] Peer reviewed and approved
[x] Signed CLA (if not already signed)

brandenTenbrink commented 2 years ago

All the changes look good to me.

Looks like there is 1 bug though. Selecting an option in the type ahead is not updating the dropdown button text.