feat(MenuDropdown): Add DoubleCaretVertical icon and trailingIcon prop to Dropdown.Button

influxdata / clockface

UI Kit for building Chronograf

https://influxdata.github.io/clockface

MIT License

44 stars 18 forks source link

feat(MenuDropdown): Add DoubleCaretVertical icon and trailingIcon prop to Dropdown.Button #804

Closed ChitlangeSahas closed 2 years ago

ChitlangeSahas commented 2 years ago

Closes: https://github.com/influxdata/clockface/issues/803

Changes

Also adds the double caret icon for menuDropdown.

Screenshots

// Add screenshots here if relevant

Checklist

Check all that apply

[ ] Updated documentation to reflect changes
[ ] Added entry to top of Changelog with link to PR (not issue)
[ ] Tests pass
[ ] Peer reviewed and approved
[ ] Signed CLA (if not already signed)

wdoconnell commented 2 years ago

Pending my two comments, this looks good to me. But we should make sure that we don't use this in the UI until the missing clockface icons are reverted.