search

influxdata / community-templates

InfluxDB Community Templates: Quickly collect & analyze time series data from a range of sources: Kubernetes, MySQL, Postgres, AWS, Nginx, Jenkins, and more.
https://www.influxdata.com/products/influxdb-templates/gallery/
Apache License 2.0
352 stars 157 forks source link

Update readme.md #187

Closed barbaranelson closed 4 years ago

barbaranelson commented 4 years ago

The readme was referring to INFLUX_HOST but the Telegraf config is using INFLUX_URL. Updated the readme to match the Telegraf config.

samhld commented 4 years ago

@mhall119 I think the convention going forward was to use INFLUX_HOST, right? Maybe I have that backwards. A number of templates use that convention and I think we need to make it uniform. I'm good to merge this if it's _URL instead. If it's confirmed that we are standardizing this, we'll need to go through a bunch of templates in either case.

barbaranelson commented 4 years ago

I could go either way. I can change it in the Telegraf config instead. Which is the convention?

Barbara.

On Sep 15, 2020, at 5:27 PM, Sam Dillard notifications@github.com wrote:

@mhall119 https://github.com/mhall119 I think the convention going forward was to use INFLUX_HOST, right? Maybe I have that backwards. A number of templates use that convention and I think we need to make it uniform. I'm good to merge this if it's _URL instead.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/influxdata/community-templates/pull/187#issuecomment-693098945, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEIXXXQNZ5ZKMOZBLIZVCLSGAA6TANCNFSM4RN7AVDQ.

samhld commented 4 years ago

@barbaranelson yeah no worries -- just waiting for Michael to confirm on that.

mhall119 commented 4 years ago

We recommend INFLUX_HOST in our docs: https://github.com/influxdata/community-templates/blob/master/docs/best_practices.md#use-environment-variables

samhld commented 4 years ago

Ah that's right. Thanks @mhall119. @barbaranelson then can you do what you did but the opposite? :)

barbaranelson commented 4 years ago

Sure. I’ll update the Telegraf config later today.

On Sep 16, 2020, at 8:24 AM, Sam Dillard notifications@github.com wrote:

Ah that's right. Thanks @mhall119 https://github.com/mhall119. @barbaranelson https://github.com/barbaranelson then can you do what you did but the opposite? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/influxdata/community-templates/pull/187#issuecomment-693479870, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEIXXWWKILWSMYVQ3SCY4TSGDKCPANCNFSM4RN7AVDQ.

barbaranelson commented 4 years ago

this was the wrong fix - instead of changing the readme, we will change the Telegraf config, as we want to standardize on INFLUX_HOST.