influxdata / flux-lsp

Implementation of Language Server Protocol for the flux language
MIT License
27 stars 5 forks source link

Composition commands should not work on invalid flux #604

Open rockstar opened 1 year ago

rockstar commented 1 year ago

When executing any composition command, we should error if the flux doesn't pass semantic checks. We cannot construct valid AST from invalid AST, and we shouldn't try to construct valid AST in bad semantic graph. The user is presented with proper diagnostics to show what needs to be corrected beforehand, so no extra functionality is needed there.

DOD: