influxdata / flux

Flux is a lightweight scripting language for querying databases (like InfluxDB) and working with data. It's part of InfluxDB 1.7 and 2.0, but can be run independently of those.
https://influxdata.com
MIT License
767 stars 153 forks source link

0.194.{3,4} failed to build against rust 1.72.0 #5438

Closed chenrui333 closed 10 months ago

chenrui333 commented 11 months ago

While upgrading rust to 1.72.0, we found some build failure with flux 0.194.3 and it is also reproducible with 0.194.4

     Compiling flux-core v0.154.0 (/private/tmp/flux-20231025-5721-1q34rp8/libflux/flux-core)
     Compiling getrandom v0.2.8
     Compiling once_cell v1.17.1
     Compiling flux v0.154.0 (/private/tmp/flux-20231025-5721-1q34rp8/libflux/flux)
  error: private item shadows public glob re-export
    --> flux/src/lib.rs:12:16
     |
  12 | use fluxcore::{Database, Flux};
     |                ^^^^^^^^
     |
  note: the name `Database` in the type namespace is supposed to be publicly re-exported here
    --> flux/src/lib.rs:16:46
     |
  16 | pub use fluxcore::{ast, formatter, semantic, *};
     |                                              ^
  note: but the private item here shadows it
    --> flux/src/lib.rs:12:16
     |
  12 | use fluxcore::{Database, Flux};
     |                ^^^^^^^^
  note: the lint level is defined here
    --> flux/src/lib.rs:1:38
     |
  1  | #![cfg_attr(feature = "strict", deny(warnings, missing_docs))]
     |                                      ^^^^^^^^
     = note: `#[deny(hidden_glob_reexports)]` implied by `#[deny(warnings)]`

  error: private item shadows public glob re-export
    --> flux/src/lib.rs:12:26
     |
  12 | use fluxcore::{Database, Flux};
     |                          ^^^^
     |
  note: the name `Flux` in the type namespace is supposed to be publicly re-exported here
    --> flux/src/lib.rs:16:46
     |
  16 | pub use fluxcore::{ast, formatter, semantic, *};
     |                                              ^
  note: but the private item here shadows it
    --> flux/src/lib.rs:12:26
     |
  12 | use fluxcore::{Database, Flux};
     |                          ^^^^

relates to: