Flux is a lightweight scripting language for querying databases (like InfluxDB) and working with data. It's part of InfluxDB 1.7 and 2.0, but can be run independently of those.
Undo the main change introduced in #5377 so that by default strings returned from array.Strings use the internal memory of the stored data. This means that it is more likely that there are some cases of use-after-free errors in the flux executor, the trade-off being that there is less likely to be a proliferation of memory allocation due to string copying. Overall use-after-free errors will not cause incorrect results with regard to strings as they are read only and the Go runtime will only free the memory once the garbage collector has determined it is unused.
Checklist
Dear Author :wave:, the following checks should be completed (or explicitly dismissed) before merging.
[x] ✏️ Write a PR description, regardless of triviality, to include the value of this PR
[ ] 🔗 Reference related issues
[ ] 🏃 Test cases are included to exercise the new code
[ ] 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
[ ] 📖 If language features are changing, ensure docs/Spec.md has been updated
Dear Reviewer(s) :wave:, you are responsible (among others) for ensuring the completeness and quality of the above before approval.
Undo the main change introduced in #5377 so that by default strings returned from
array.Stringsuse the internal memory of the stored data. This means that it is more likely that there are some cases of use-after-free errors in the flux executor, the trade-off being that there is less likely to be a proliferation of memory allocation due to string copying. Overall use-after-free errors will not cause incorrect results with regard to strings as they are read only and the Go runtime will only free the memory once the garbage collector has determined it is unused.Checklist
Dear Author :wave:, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) :wave:, you are responsible (among others) for ensuring the completeness and quality of the above before approval.