influxdata / giraffe

A foundation for visualizations in the InfluxDB UI
https://influxdata.github.io/giraffe/
MIT License
183 stars 34 forks source link

fix: put Single Stat default styles into stylesheet to prevent font flashing #822

Closed TCL735 closed 2 years ago

TCL735 commented 2 years ago

Part of https://github.com/influxdata/ui/issues/5993

BEFORE: notice the font changes thickness

https://user-images.githubusercontent.com/10736577/194672131-1006aea7-5f7c-4c0c-9222-0d4dd55a9892.mp4

AFTER: no change in thickness of the font

https://user-images.githubusercontent.com/10736577/194672152-726f3954-1e81-4485-8c6c-ecaa1eaa1f2f.mp4

TCL735 commented 2 years ago

Nice work!

Only question: should the font be the heavy / bold version? do our designers haven an opinion on this?

Good question. I copied these same font settings from Clockface. i will make sure to update them when they are updated in Clockface.