influxdata / giraffe

A foundation for visualizations in the InfluxDB UI
https://influxdata.github.io/giraffe/
MIT License
183 stars 33 forks source link

Visualization: Table: re-port from UI codebase without architectural changes #824

Open TCL735 opened 1 year ago

TCL735 commented 1 year ago

There are a couple of nagging issues with Table that should be fixed. As one of the fundamental visualizations, there shouldn't be any bugs associated with Table. And even though there may be pending design and product changes for Table, the existing stuff should work.

Proposal

Instead of porting the Table visualization code from the UI with changes (by attempting to use functional components rather than class components), the port should just be exactly as-is with only minimal and necessary changes. Also, any minor bugs should be fixed. But none of this should be done by changing the underlying code architect such as moving from class components to functional components. The differences between these two implementations may be the reason for the nagging issues.

Specifically, by doing the above, we are consolidating and hoping to address the following: https://github.com/influxdata/giraffe/issues/788
https://github.com/influxdata/ui/issues/6147