RFC3164

[leodido]

This PR finally implements RFC3164 parsing! 😃

It fixes #15 when merged in.

Notice it changes the syslog.Message interface and it introduces a syslog.Base struct containing the common fields between the two Syslog formats.

This means I'll need to release another major (v3) when completed 100% (see below).

Missing pieces at the moment:

• [ ] extensive test suite
• [x] option/mechanism to let the user choose the year of the timestamp
• [x] best-effort mode
• [x] option to choose the year for STAMP timestamps (WithYear() with strategies like CurrentYear{}, Year{YYYY:2020} etc.)
• [x] option to choose the time zone for STAMP timestamps (WithTimezone())
• [x] option to let the parser ALSO match RFC3339 timestamps (WithRFC3339())
• [x] examples
• [x] update README with examples referring to the new interfaces (#26)

[gianarb]

Hello @leodido ! Thank you for this contrib

--- FAIL: TestMachineParse (0.00s)
    --- FAIL: TestMachineParse/<34>Jan_12_06:30:00_xxx_apache_server:_1.2.3.4_-_- (0.00s)
        <autogenerated>:1: 
                Error Trace:    machine_test.go:49
                Error:          Should NOT be empty, but was &{<nil> <nil> <nil> 0 <nil> <nil> <nil> <nil> <nil> <nil> <nil>}
                Test:           TestMachineParse/<34>Jan_12_06:30:00_xxx_apache_server:_1.2.3.4_-_-
FAIL

This is the failing test atm

[leodido]

This was the reason I put the PR as a draft (with WIP prefix). Anyway I have other commits to push :)

[leodido]

greeeeeeeny 💚

[leodido]

@goller I want your review my friend plzzz 🤗

But please DO NOT merge yet :)

[goller]

@leodido you rock!

I think I'll start by reading through the structural changes.

Next, I'll read 3164 again and look closely at the grammar.

[russorat]

Really looking forward to this!!!

[leodido]

Hey, @goller your test (https://github.com/influxdata/go-syslog/pull/27/commits/db2b9df413ba9a2f76f4d4cdec4b0e07d8eda753) was not passing because of missing whitespace at the start of the MSG part.

If you think that such BSD-syslog messages (no whitespace space between the TAG/CONTENT end - ':' - and the MSG start) are very common we could think to provide an option to parse them as correct ones.

[leodido]

Friendly ping! @goller 😃

[russorat]

is this really happening?! I'm so excited! Thank you for the great work here @leodido !