[v1 shell] Shell does not properly clean up the terminal

elyscape commented 2 years ago

When quitting the InfluxQL shell, it doesn't properly clean up the terminal. This results in the user needing to run stty sane in order to restore proper functioning of their terminal (e.g. echo of keys typed).

Steps to reproduce:

Run influx v1 shell
Type quit to quit
Enter a new command on the command line

Expected behavior: The terminal behaves as it did prior to launching influx v1 shell.

Actual behavior: Typed characters are not echoed to the console.

Environment info:

System info:
- Darwin 21.6.0 arm64
- Linux 5.15.56-v8+ aarch64
Influx version:
- macOS: Influx CLI 2.4.0 (git: 5c7c34f16d) build_date: 2022-08-18T18:21:50Z
- Linux: Influx CLI 2.4.0 (git: 5c7c34f) build_date: 2022-08-18T19:26:48Z

Root cause: This happens due to c-bata/go-prompt#228 (see my comment for an explanation). A fix is available in c-bata/go-prompt#263.

elyscape commented 2 years ago

I went ahead and opened influxdata/go-prompt#1 to get the fix into your fork of go-prompt.

elyscape commented 1 year ago

Pinging @candrewlee14 and @lesam, who worked on this.

influxdata / influx-cli

[v1 shell] Shell does not properly clean up the terminal #441