influxdata / influxdata-operator

A k8s operator for InfluxDB
MIT License
76 stars 32 forks source link

m2:add unit tests for new code & add azure PV support & upsizing #2

Closed pydevops closed 5 years ago

pydevops commented 5 years ago

@dustinbarnes

pydevops commented 5 years ago

This is looking solid. One question: Did you mean to commit these tar.gz files?

pkg/storage/testdata/backup/20190124T234601Z.s7.tar.gz -- there's a few of them.

I copied some sample data here for unit testing. What is the best practice of using them? thanks

dustinbarnes commented 5 years ago

Eh, I think that's sufficient. I just wanted to make sure we weren't putting any extra cruft into the repo.

On Wed, Jan 30, 2019 at 12:55 PM Victor Yang notifications@github.com wrote:

This is looking solid. One question: Did you mean to commit these tar.gz files?

pkg/storage/testdata/backup/20190124T234601Z.s7.tar.gz -- there's a few of them.

I copied some sample data here for unit testing. What is the best practice of using them? thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/influxdata/influxdata-operator/pull/2#issuecomment-459105388, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXkB0BPsS09IMMhkKOC5ggQltXNQBBEks5vIgbXgaJpZM4aYzXo .