influxdata / influxdb-client-csharp

InfluxDB 2.x C# Client
https://influxdata.github.io/influxdb-client-csharp/api/InfluxDB.Client.html
MIT License
361 stars 92 forks source link

Add ability to pass in offset time when creating alerts via API #580

Open cklenk opened 1 year ago

cklenk commented 1 year ago

Proposal: Add offset to CreateThresholdCheckAsync and CreateDeadmanCheckAsync for alerting

Current behavior: Unable to set offset time when using CreateThresholdCheckAsync and CreateDeadmanCheckAsync methods

Desired behavior: Pass in optional offset time with functions

Alternatives considered: Manually create alerts

Use case: Ease of development and cleaner solution

powersj commented 1 year ago

Hi,

When you say offset time, what is your use-case for this offset? Is it a delay in notification?

Thanks

cklenk commented 1 year ago

Yes, that is correct. To account for late data that might come in.

Thanks, Cameron

powersj commented 1 year ago

Based on the API docs, it does look like the threshold type check has a offset parameter that is not exposed in this client library.

We can investigate this further, but would also be happy to see a PR with a fix to include this parameter.

Thanks!