Open oliverrahner opened 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.39%. Comparing base (
dc1d442
) to head (8f23758
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Good thing you asked about the integration tests... turns out my fix doesn't work :-/ I'll work on it.
So, this probably still is true: https://github.com/influxdata/docs.influxdata.com-ARCHIVE/issues/2676 I've opened a new docs issue here: https://github.com/influxdata/docs-v2/issues/5481
Not fully aware of this library's policy, should it try to inform the user about the actual cause of the issue, such as a tag value ending in a backslash? Or should this be left to the Influx daemon (which doesn't do a good job explaining the issue in this case)?
Independent from this question, the actual change introduced with this PR is probably still a good idea.
Closes #718
Proposed Changes
Backslashes should also be escaped. This is generally optional in InfluxDB, but in special cases such as the end of a tag value, it might become crucial
Checklist
mvn test
completes successfully