Closed sokil closed 1 year ago
Patch coverage has no change and project coverage change: -0.07
:warning:
Comparison is base (
5ff8234
) 74.93% compared to head (123f1dd
) 74.86%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
done
@sokil thanks again for PR 👍
Thank you for quick feedback!!
Proposed Changes
If UPD socket was previously closed by
\InfluxDB2\UdpWriter::close
and new write occured, error will be obtainedsocket_sendto(): Argument #1 ($socket) has already been closed
This is because method
close
does not unset socket property:And
getSocket
does not create new connection because old still insocket
property:Checklist
make test
completes successfully