Closed swssl closed 6 months ago
Hi @swssl,
thanks for using our client.
Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.
Regards
Hi @bednar , thanks for your reply. Unfortunately, i won't be available to work on this on short notice but i'll keep it in mind.
Hey all, FYI, urllib3 v2.1.0 was released last week: https://github.com/urllib3/urllib3/releases/tag/2.1.0 As far as I can tell, it doesnt contain the changes the warning is about. @bednar Maybe I will be able to work on this in the end of January.
@swssl, thanks 🙏
Specifications
Code sample to reproduce problem
Every call of
HTTPResponse.getheader()
andHTTPResponse.getheaders()
.Expected behavior
Work without Deprecation Warnings.
Actual behavior
The following warnings are raised:
HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default).
HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
Additional info
See https://github.com/urllib3/urllib3/blob/53368dfe6609aec8f3d933b62021cf568f24b794/src/urllib3/response.py#L478C6-L478C6 for warning origin.