fix: memory leaks - Githubissues

influxdata / influxdb-client-swift

InfluxDB (v2+) Client Library for Swift

https://influxdata.github.io/influxdb-client-swift/

MIT License

26 stars 8 forks source link

fix: memory leaks #64

Closed dankinsoid closed 4 months ago

dankinsoid commented 4 months ago

Closes #63 Closes #65

Proposed Changes

Replace classes with structs and lazy vars with computed vars

Checklist

[x] CHANGELOG.md updated
[x] Rebased/mergeable
[x] A test has been added if appropriate
[x] swift test completes successfully
[x] Commit messages are conventional
[x] Sign CLA (if not already signed)

dankinsoid commented 4 months ago

@bednar swift test doesn't pass on master branch, it waits for http://localhost:8086/

dankinsoid commented 4 months ago

I don't know how to fix the last one

dankinsoid commented 4 months ago

@bednar Hello! Do I need to do smth to merge the PR? I need it for my library

bednar commented 4 months ago

Thanks again for your PR 👍. I will merge at Monday and after that we will release new version of the client.

bednar commented 4 months ago

Hi @dankinsoid,

I wanted to give you an update on the progress we're making with your Pull Request. I've prepared PR #66 to address some CI checks issues we've been facing. Once PR #66 is reviewed and merged, we will be able to proceed with merging your PR as well.

As mentioned yesterday, we are on track to release the new version of the client, which will include your fix, by the end of this week.

Thank you for your patience and your contributions. I'll keep you updated as we move forward.

Best regards

dankinsoid commented 4 months ago

@bednar thank you!

bednar commented 4 months ago

@dankinsoid, the PR has been merged. Thank you very much once again for your contribution!