search

influxdata / influxdb-java

Java client for InfluxDB
MIT License
1.17k stars 476 forks source link

Throw if a non-`Instant` field is annotated with `@TimeColumn` #974

Closed eranl closed 7 months ago

eranl commented 7 months ago

Currently, if a non-Instant field is annotated with @TimeColumn, it is silently ignored. With this change, it will result in an exception. This change is breaking for any existing code that relies on the current silent failure.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e5518be) 61.27% compared to head (4ab9916) 61.35%.

:exclamation: Current head 4ab9916 differs from pull request most recent head c32a18c. Consider uploading reports for the commit c32a18c to get more accurate results

Files Patch % Lines
src/main/java/org/influxdb/dto/Point.java 93.33% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #974 +/- ## ============================================ + Coverage 61.27% 61.35% +0.08% Complexity 450 450 ============================================ Files 70 70 Lines 2590 2593 +3 Branches 277 278 +1 ============================================ + Hits 1587 1591 +4 Misses 932 932 + Partials 71 70 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.